[Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE) $(TARGET_CONFIGURE_OPTS)

[Bernhard Fischer]

On Mon, Jul 09, 2007 at 10:25:50AM +0200, Bernhard Fischer wrote:
>On Sun, Jul 08, 2007 at 12:49:20AM +0200, Ulf Samuelsson wrote:
>>> On Sat, Jul 07, 2007 at 09:37:05PM +0200, Ulf Samuelsson wrote:

>>Stephen, can you pls review the mtd part of this patch ASAP,
>>since this breaks the build for ARM (and possibly all non-x86).
>>Pls commit (or ack my commit) if OK.
>
>I've applied this now and will fix the other breakage due to not passing
>CFLAGS any longer, thus building with package-imposed incorrect flags.

Steven,

This hunk of yours is really broken:
TARGET_CONFIGURE_OPTS=... \
                CC="$(TARGET_CROSS)gcc $(TARGET_CFLAGS)" \
                GCC="$(TARGET_CROSS)gcc $(TARGET_CFLAGS)" \
                CXX="$(TARGET_CROSS)g++ $(TARGET_CFLAGS)" \
                CPP="$(TARGET_CROSS)cpp $(TARGET_CFLAGS)" \

1) These are the compilers and not compiler plus flags.
2) CFLAGS are wrong as CXXFLAGS
3) since your change we end up using the default flags from the
packages, which more often than not default to -O2. Let me refer you to
options.c of gcc (or the respective docs for the gory details).

I am going to revert this change for now. What were you trying to
do/solve?