[Buildroot] svn commit: trunk/buildroot

[Bernhard Fischer]

On Mon, Jul 07, 2008 at 03:47:11PM +0200, Ulf Samuelsson wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>Bernhard Fischer skrev:
>> On Mon, Jul 07, 2008 at 03:25:27PM +0200, Ulf Samuelsson wrote:
>> [snip ugly log target]
>>>> As mentioned earlier, it doesn't work with Makefile.autotools.in using
>>>> packages.
>>>>
>>> Yes, but that is really not a good implementation.
>>> The MAKELEVEL has really nothing to do with what you
>>> want to use it for, it just happens to work, but
>>> this implementation is easily broken.
>> 
>> I have to agree to Ulf in this respect, fwiw.
>> Peter, why did you have to take MAKELEVEL into account? Perhaps we can
>> fix this in a better way.. (pointing me to a detailed commit-message or
>> to the ML archives is sufficient)
>
>This is my proposal (which started this thread),
>but I would like you guys to comment.
>
>Index: Makefile
>===================================================================
>- --- Makefile	(revision 22671)
>+++ Makefile	(arbetskopia)
>@@ -346,10 +346,10 @@
> source: $(TARGETS_SOURCE) $(HOST_SOURCE)
>
> _source-check:
>- -	$(MAKE) SPIDER=--spider source
>+	$(MAKE) FORCE_DOWNLOAD=y SPIDER=--spider source

No, this is not acceptable.
>
> external-deps:
>- -	@$(MAKE) -Bs BR2_WGET=$(TOPDIR)toolchain/wget-show-external-deps.sh \
>+	@$(MAKE) FORCE_DOWNLOAD=y -Bs

>BR2_WGET=$(TOPDIR)toolchain/wget-show-external-deps.sh \
> 	source
>
>Index: package/Makefile.autotools.in
>===================================================================
>- --- package/Makefile.autotools.in	(revision 22671)
>+++ package/Makefile.autotools.in	(arbetskopia)
>@@ -131,7 +131,7 @@
> # Retrieve and unpack the archive
> $(BUILD_DIR)/%/.stamp_downloaded:
> # support make source-check/external-deps
>- -ifeq ($(MAKELEVEL),1)
>+ifeq ($(FORCE_DOWNLOAD),y)
> 	$(WGET) -P $(DL_DIR) $($(PKG)_SITE)/$($(PKG)_SOURCE)
> 	$(if $($(PKG)_PATCH),$(WGET) -P $(DL_DIR) $($(PKG)_SITE)/$($(PKG)_PATCH))
> else

What are you trying to do, Peter? source-check should work just fine,
even for autotools.in