[Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands

[Allan Nielsen]

Hi Thomas

Sorry for not replaying the last couple of days, but I have been busy
with some other concerns.

However, when I did a rebuild I did also realize the problems with the
solution I suggested. Since then I changed the extract_cmd statement
to also the same as you have suggested:

430 $(2)_EXTRACT_CMDS ?= $(if $$($(2)_SOURCE),$$(INFLATE$$(suffix
$$($(2)_SOURCE))) $(DL_DIR)/$$($(2)_SOURCE) | \
431 »·······$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR) $(TAR_OPTIONS) -)

This solution has been working fine for me, (and it should make no
difference if I changes it to your suggestion).

Anyways, I would like to know where you stand on this, do you think
this solution to be included in buildroot or would you prefer to wait
for a better suggestion?

Regards


On Mon, May 16, 2011 at 9:52 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello Allan,
>
> On Tue, 10 May 2011 20:43:32 +0200
> Thomas Petazzoni <thomas.petazzoni at free-electrons.com> wrote:
>
>> > +# default extract command
>> > +$(2)_EXTRACT_CMDS ?= $(if $($(2)_SOURCE),$(INFLATE$(suffix
>> > $($(2)_SOURCE))) $(DL_DIR)/$($(2)_SOURCE) | \
>> > +   $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR)
>> > $(TAR_OPTIONS) -)
>>
>> Hm, this is not some nice. I'm currently testing your patch, I'll see
>> if I find a better way of writing this.
>
> I haven't really searched a better way of writing this, but I've used
> your patch and found some problem with it. It does not quote
> sufficiently the variables, so things break with host packages.
>
> I have been able to get things working with:
>
> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> index 9949b58..0a4c220 100644
> --- a/package/Makefile.package.in
> +++ b/package/Makefile.package.in
> @@ -425,7 +425,8 @@ $(2)_TARGET_CLEAN =         $$($(2)_DIR)/.stamp_cleaned
>  $(2)_TARGET_DIRCLEAN =         $$($(2)_DIR)/.stamp_dircleaned
>
>  # default extract command
> -$(2)_EXTRACT_CMDS ?= $(if $($(2)_SOURCE),$(INFLATE$(suffix $($(2)_SOURCE))) $(DL_DIR)/$($(2)_SOURCE) | \
> +$(2)_EXTRACT_CMDS ?= \
> +       $$(if $$($(2)_SOURCE),$$(INFLATE$$(suffix $$($(2)_SOURCE))) $(DL_DIR)/$$($(2)_SOURCE) | \
>        $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR) $(TAR_OPTIONS)
>        -)
>
> On top of what you did.
>
> Regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>