[Buildroot] [PATCH 2/2] lsof: add busybox tweaks

Peter Korsgaard jacmet at uclibc.org
Sun Apr 29 08:36:05 UTC 2012


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

Hi,

 >> > Now, whether we should change those guidelines to something else is a
 >> > different story. But if we change the guideline, it should be changed
 >> > for all packages and not just for lsof.
 >> package/kmod/Config.in is already like this

The main reason why it's done like this is that it's only the _TOOLS
suboption that should depend on the _SHOW_OTHERS option.

 >> and it's more clean

 Arnout>  I agree that it's better to do it in the package's Config.in.

 Arnout>  And changing the guideline doesn't automatically mean that all
 Arnout> packages have to change.  Only new packages (or patches) must follow 
 Arnout> the guideline.

True. But the first thing to decide on is if this _SHOW_OTHERS option is
really useful. It was afaik introduced long time ago to encourage people
to use the busybox applets instead of the full blown versions, but
perhaps we should just let people decide for themselves?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list