[Buildroot] [PATCH 1/2] package/spice: don't enable GUI if dependencies not met

Peter Korsgaard jacmet at uclibc.org
Wed Dec 26 22:51:55 UTC 2012


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 Yann> The spice GUI selects unconditionally selects cegui06, but cegui06 requires
 Yann> threads and C++, so spice GUI must also depend on threads and C++.

 Yann> Fixes:
 Yann>     http://autobuild.buildroot.net/results/37f8ee90bb4348db97daef83493005c42a193b91/

 Yann> +++ b/package/spice/Config.in
 Yann> @@ -35,8 +35,13 @@ config BR2_PACKAGE_SPICE_CLIENT
 Yann>  	select BR2_PACKAGE_XLIB_LIBXFIXES
 Yann>  	select BR2_PACKAGE_XLIB_LIBXRANDR
 
 Yann> +comment "GUI requires a toolchain with threads and C++"
 Yann> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 Yann> +

This comment should only be shown if SPICE_CLIENT is enabled, so I've
added the dependency and committed, thanks.

 Yann>  config BR2_PACKAGE_SPICE_GUI
 Yann>  	bool "Enable GUI"
 Yann> +	depends on BR2_TOOLCHAIN_HAS_THREADS    # cegui06
 Yann> +	depends on BR2_INSTALL_LIBSTDCPP        # cegui06

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list