[Buildroot] [PATCH] New package: xinetd

Peter Korsgaard jacmet at uclibc.org
Mon May 28 19:49:22 UTC 2012


>>>>> "Danomi" == Danomi Manchego <danomimanchego123 at gmail.com> writes:

Hi,

 Danomi> Signed-off-by: Danomi Manchego <danomimanchego123 at gmail.com>
 Danomi> ---
 Danomi>  package/Config.in                              |    1 +
 Danomi>  package/xinetd/Config.in                       |    8 +++
 Danomi>  package/xinetd/xinetd-2.3.15/001-ar.patch      |   66 ++++++++++++++++++++++++
 Danomi>  package/xinetd/xinetd-2.3.15/002-destdir.patch |   27 ++++++++++
 Danomi>  package/xinetd/xinetd-2.3.15/003-rpc_fix.patch |   19 +++++++

Please add a git-style header to each patch specifying the authorship
and a description of what they do + your signed-off-by.

 Danomi> +++ b/package/xinetd/xinetd.mk
 Danomi> @@ -0,0 +1,13 @@
 Danomi> +#############################################################
 Danomi> +#
 Danomi> +# xinetd
 Danomi> +#
 Danomi> +#############################################################
 Danomi> +XINETD_VERSION      = 2.3.15
 Danomi> +XINETD_SOURCE       = xinetd-$(XINETD_VERSION).tar.gz

Minor detail: This is the default value for _SOURCE, so you can skip
this line.

 Danomi> +XINETD_SITE         = http://www.xinetd.org
 Danomi> +XINETD_CONF_OPT     =
 Danomi> +XINETD_DEPENDENCIES =

No need to these two lines either.

 Danomi> +
 Danomi> +$(eval $(call AUTOTARGETS))
 Danomi> +

Please no trailing line.

Otherwise it looks good - Care to fix and resend?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list