[Buildroot] [PATCH v2] pkg-download: take some more care of <PKG_>VERSION with git

[Thomas De Schampheleire]

On Tue, Aug 13, 2013 at 6:40 PM, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 13/08/13 12:15, Thomas Petazzoni wrote:
>>
>> Hello,
>>
>> On Tue,  2 Apr 2013 21:40:08 +0200, Patrick Boettcher wrote:
>>>
>>> This replaces the one-liner patch I made last week after a comment by
>>> Thomas De Schampheleire. (it is now a 5-liner)
>>>
>>> I added comment to explain why using HEAD is better in the current
>>> situation. I did not change the hg-part as it is different to git -
>>> after a quick read it won't work at all when VERSION is not set in a
>>> packge.
>>>
>>> Please apply if appropriate and helpful (it is for me).
>>>
>>> Patrick Boettcher (1):
>>>    pkg-download: take some more care of <PKG_>VERSION when METHOD is git
>>>
>>>   package/pkg-download.mk |    6 +++++-
>>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>>
>> Thomas, Arnout, Gustavo, some thoughts about this patch?
>>
>> I'm not a big fan of the fact that <pkg>_VERSION would be optional for
>> the git site method, but mandatory for the hg site method, but it's not
>> really a strong opinion.
>
>
>  Considering the commit message of 3a7a0a which you just committed:
>
> "Specifying a floating tag like HEAD for a repository version is bad
> practice, as it results in non-reproducible builds."
>
> I would say this is a bad idea. Instead, there could be a check that
> PKG_VERSION is not empty.

I agree with this suggestion, this would be a better solution for the
mentioned problem.

Best regards,
Thomas