[Buildroot] [PATCH 2/3] qt5: version bump
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Dec 20 09:57:15 UTC 2013
Dear Peter Korsgaard,
On Thu, 19 Dec 2013 16:35:24 +0100, Peter Korsgaard wrote:
> >>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:
>
> > -bump version to 5.2.0
> > -remove unneeded patches
> > -remove invalid configure options
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> > ---
> > package/qt5/qt5.mk | 4 +-
> > ...-Add-egl-cflags-when-opengles2-is-enabled.patch | 32 ----
> > .../qt5/qt5base/qt5base-0003-uclibc-no-lfs.patch | 36 -----
>
> This patch is still needed.
>
> > package/qt5/qt5base/qt5base-0008-qatomic-ppc.patch | 29 ----
>
> And so is this.
IMO, this is a good reason, for package bumps, to *require* in the
commit log some details about how patches are updated: why some patches
are removed, some others added, and the others updated. By requiring
this, we will really encourage people to think about the patches, and
provide a justification as to why an existing patch is no longer needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list