[Buildroot] [autobuild.buildroot.net] Build results for 2014-04-10
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Apr 11 12:13:46 UTC 2014
Dear Mike Zick,
On Fri, 11 Apr 2014 06:51:58 -0500, Mike Zick wrote:
> > > This looks weird, and I don't have a good explanation. For now,
> > > I've removed this bogus file, and we'll see if this occurs again
> > > in the future.
> >
> > Agreed. Thanks for looking into it!
> >
>
> That reads like wget behavior, if interrupted and without the
> "continue" option.
Our wget download method normally downloads to a different temporary
file, and then moves the temporary file to the final location once the
download was successful. Hum, but it doesn't remove the temporary file
*before* starting the download:
define DOWNLOAD_WGET
test -e $(DL_DIR)/$(2) || \
($(WGET) -O $(DL_DIR)/$(2).tmp '$(call qstrip,$(1))' && \
mv $(DL_DIR)/$(2).tmp $(DL_DIR)/$(2)) || \
(rm -f $(DL_DIR)/$(2).tmp ; exit 1)
endef
So if you have the following sequence:
1/ wget downloads into tarball.tar.gz.tmp
2/ wget is interrupted by Ctrl+C, the .tmp file remains
3/ the build is restarted, so wget runs again, and downloads the file
again
4/ the download is successful, and the .tmp file is renamed to the
final name
Would this sequence be possible?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list