[Buildroot] [PATCH] u-boot: Allow to specify a list of patches
Arnout Vandecappelle
arnout at mind.be
Thu Jul 17 23:20:07 UTC 2014
On 17/07/14 19:23, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2014-07-17 09:48 +0200, Arnout Vandecappelle spake thusly:
>> On 17/07/14 06:52, Thomas De Schampheleire wrote:
>>> Arnout Vandecappelle <arnout at mind.be> schreef:
>>>> On 15/07/14 22:13, Yann E. MORIN wrote:
>>>>> The more I think about it, the more I find our policy to require
>>>>> PKG-prefixed patches to be really cumbersome, since the patches already
>>>>> are in a subdir named PKG/
>>>>>
>>>>> Of course, we're enforcing this naming scheme in BR2_GLOBAL_PATCH_DIR to
>>>>> be in sync with what we do for our bundled patches.
>>>>>
>>>>> But still, if patches were just named NNNN-title.patch, that would be as
>>>>> efficient at sorting the patches. The PKG- prefix is not really
>>>>> required, and indeed can cause some troubles with some use-cases, such
>>>>> as yours.
>>>>>
>>>>> Thomas, was there a specific reason we wanted the patches to be
>>>>> PKG-prefixed? If not, would it make sense to just accept patches without
>>>>> a PKG-prefix?
>>>>
>>>> Er, we don't... We require this specific naming scheme for contributed
>>>> packages, but the code itself just takes *.patch.
>>>
>>> Yes sure, it's a convention only, but the question is: why did we include the package name in the convention?
>>
>> I think it's purely historical. And I think it never was required for patches
>> in a <pkgname> subdir.
>
> So we could change the manual to not require patches to be PKG-prefixed?
>
> As long as they are number-prefixed, that's all we need, right?
>
> So, Ezequiel's patch is really no longer needed, and his use-case to use
> git-formatted patches is already covered, right?
Yep.
Untested, of course :-)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
More information about the buildroot
mailing list