[Buildroot] [PATCH v2 6/8] package/mpd: enable support for libnfs

[Thomas Petazzoni]

Dear Jörg Krause,

On Wed, 15 Oct 2014 15:18:52 +0200, Jörg Krause wrote:

> +ifeq ($(BR2_PACKAGE_MPD_LIBNFS),y)
> +PKG_CONFIG_PATH = "$(STAGING_DIR)/usr/lib/pkgconfig"

This looks wrong, for two reasons:

 *) A package is not allowed to change global variables. Remember that
    the namespace of variables in global, so if one package is changing
    a global variable, this change is visible to all other packages.

 *) $(STAGING_DIR)/usr/lib/pkgconfig is already the default search path
    for our pkg-config, so there should be no need to make this tuning.
    Which problem have you seen?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com