[Buildroot] [PATCH 1/1] ympd: new package (version 2)

[Eric Limpens]

I'll add the license and dependency statements and will modify the patch to
use the more elegant approach suggested by Samuel.

Thanks for your input, Eric.

On Fri, Sep 26, 2014 at 9:11 PM, Peter Korsgaard <jacmet at uclibc.org> wrote:

> >>>>> "Eric" == Eric Limpens <limpens at gmail.com> writes:
>
>  > Signed-off-by: Eric Limpens <limpens at gmail.com>
>  > ---
>  >  package/Config.in                                       |  1 +
>  >  package/ympd/Config.in                                  | 10 ++++++++++
>  >  package/ympd/ympd-0001-CMake-cross-compile-mkdata.patch | 16
> ++++++++++++++++
>  >  package/ympd/ympd.mk                                    | 16
> ++++++++++++++++
>  >  4 files changed, 43 insertions(+)
>  >  create mode 100644 package/ympd/Config.in
>  >  create mode 100644
> package/ympd/ympd-0001-CMake-cross-compile-mkdata.patch
>  >  create mode 100644 package/ympd/ympd.mk
>
>  > +++ b/package/ympd/ympd-0001-CMake-cross-compile-mkdata.patch
>  > @@ -0,0 +1,16 @@
>  > +CMakeLists.txt: make it cross-compile friendly. Upstream is looking
> into a proper solution.
>  > +
>  > +Signed-Off-by: Eric Limpens <Limpens at Gmail.com>
>  > +
>  > +--- ympd-a98d760dddff4b0dd595d977c9077f34beff05c5/CMakeLists.txt
> 2014-05-24 15:25:47.000000000 +0200
>  > ++++ ympd-a98d760dddff4b0dd595d977c9077f34beff05c5-1/CMakeLists.txt
> 2014-09-23 20:04:55.491997850 +0200
>  > +@@ -29,6 +29,7 @@
>  > + )
>  > +
>  > +-add_executable(mkdata htdocs/mkdata.c)
>  > +-get_target_property(MKDATA_EXE mkdata LOCATION)
>  > ++#add_executable(mkdata htdocs/mkdata.c)
>  > ++#get_target_property(MKDATA_EXE mkdata LOCATION)
>  > ++set(MKDATA_EXE "./mkdata")
>
>
> It seems like you missed Samuels' feedback?
>
>  > +
>  > + add_custom_command(OUTPUT ${PROJECT_BINARY_DIR}/assets.c
>  > diff --git a/package/ympd/ympd.mk b/package/ympd/ympd.mk
>  > new file mode 100644
>  > index 0000000..33fd4ec
>  > --- /dev/null
>  > +++ b/package/ympd/ympd.mk
>  > @@ -0,0 +1,16 @@
>  >
> +################################################################################
>  > +#
>  > +# ympd
>  > +#
>  >
> +################################################################################
>  > +
>  > +YMPD_VERSION = a98d760dddff4b0dd595d977c9077f34beff05c5
>  > +YMPD_SITE = $(call github,notandy,ympd,$(YMPD_VERSION))
>
> What about license?
>
> You need to add MPD_DEPENDENCIES = libmpdclient to ensure libmpdclient
> gets built before ympd.
>
> --
> Bye, Peter Korsgaard
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20140927/deea39c7/attachment-0001.html>