[Buildroot] [PATCH v8 5/7] package/opencv: add gtk3 support

[Thomas Petazzoni]

Dear Samuel Martin,

On Sun,  5 Jul 2015 11:40:27 +0200, Samuel Martin wrote:
> Fully rework the GTK support in OpenCV because it now supports gtk-2 and
> gtk-3 (but only one at the time).
> Note that, in the build-system, the gtk support is only available when
> Qt support is disabled; so make sure the menuconfig reflects this.

Nothing in the patch is doing that. You're anyway using a "choice", so
the user can only decide one of gtk2, gtk3, qt4 or qt5. So this comment
in the commit log doesn't make sense.


> +config BR2_PACKAGE_OPENCV_WITH_GTK3
> +	bool "gtk3"
> +	depends on BR2_ARCH_HAS_ATOMICS # libgtk3 -> cairo
> +	depends on BR2_USE_MMU # libgtk3 -> libglib2
> +	depends on BR2_USE_WCHAR # libgtk3 -> libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk3 -> libglib2
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	select BR2_PACKAGE_LIBGTK3

Please use a depends on BR2_PACKAGE_LIBGTK3, so that things are
consistent with qt4 and qt5 (unless of course you switch to a select
for Qt4/Qt5 following my previous comments). But in any case, be
*consistent*.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com