[Buildroot] [PATCH V4] sdl2: new package

[Thomas Petazzoni]

Hello,

On Mon, 06 Jul 2015 14:17:11 +0200, Guillaume GARDET - Oliséo wrote:

> No, I won't. It is extra work for nothing. I think it is not so complicated to review only 2 files to add a new package. Splitting packages for u-boot or Linux kernel make sense most of the time, but, here, clearly no.
> Buildroot maintainers/reviewers should send their comments from the 1st version, not 1 guy comments on V1, someone else on V2 etc., again the first guy for V3 on another part of the patch which was not commented the 1st time.
> 
> I contribute to lots of open source / free software and contributing to Buildroot is really painful compared to other projects. So please, all send your comments at the same time.
> For SDL2, please send your comments this week, and I will send a V5 next week fixing the remaining bits and if it does not fit to another guy again, I will stop sending patches to Buildroot.
> Now, I understand better why some people are maintaining a buildroot fork instead of upstreaming their patches. So, please improve your patch submission/review process.

Could you use an e-mail client that wraps lines at a reasonable length?

Regarding the patch submission/review process, we merge tons and tons
of patches all the time. However, it is true that we tend to merge
patches from people who also help in reviewing patches from others. I
don't think I've seen patch reviews/tests from you. It would definitely
help in increasing the trust that the maintainers have in your patches,
and therefore make them look at your patches faster.

Did you look at http://patchwork.ozlabs.org/project/buildroot/list/ ?
This is the complete list of pending patches we have, which as you can
see is quite long. Your help is definitely welcome to reduce this list,
by reviewing, testing and commenting patches from others.

And if you think that the entire community can synchronize to send all
the comments on the v1, then it clearly means that you have never
contributed to the Linux kernel, or at least not significant patches.
It is very common to get some comments on v1, then some other comments
on v2 (from different persons, or even from the same person who
realized some more issues). That's definitely not something you can
expect from an open-source community.

However, I do agree that we could do better to reply to patches in a
timely fashion. And to make this happen, we need *your* help to look at
patches from others.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com