[Buildroot] [PATCH 1/1] ntfs-3g: fix incorrect comment dependency

Ryan Barnett ryan.barnett at rockwellcollins.com
Mon Jul 13 20:35:32 UTC 2015


Thomas,

On Mon, Jul 13, 2015 at 3:32 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Ryan Barnett,
>>
>>  comment "ntfs-3g needs a toolchain w/ wchar, threads, dynamic library"
>>       depends on BR2_USE_MMU
>> -     depends on !(BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS && BR2_STATIC_LIBS)
>> +     depends on !(BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS && !BR2_STATIC_LIBS)
>
> I personally prefer:
>
>         depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
>
> I think we do that for most packages, and it's somewhat easier to understand.

OK - I really don't have a preference but I agree for consistency
across buildroot it would be better to change to what you suggested.

I will submit a v2 here.

Thanks,
-Ryan

-- 
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com



More information about the buildroot mailing list