[Buildroot] [PATCH 16/32 v2] package/matchbox-common: fix dependencies

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Wed,  3 Jun 2015 22:41:33 +0200, Yann E. MORIN wrote:
> matchbox-common can be used by both matchbox-desktop and matchbox-panel,
> so it needs to depend on either, not both.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
>  package/matchbox-common/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/matchbox-common/Config.in b/package/matchbox-common/Config.in
> index 33d6cc4..5a038e1 100644
> --- a/package/matchbox-common/Config.in
> +++ b/package/matchbox-common/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_MATCHBOX_COMMON
>  	bool "matchbox-common"
>  	select BR2_PACKAGE_MATCHBOX_LIB
> -	depends on BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP
> +	depends on BR2_PACKAGE_MATCHBOX_PANEL || BR2_PACKAGE_MATCHBOX_DESKTOP
>  	help
>  	  Common desktop folders and matchbox-session script.
>  

I'll apply because I want to apply the rest of the series, but why are
we doing this in the first place? I don't think packages in Buildroot
have a "depends on" on things that can *use* them. The dependencies in
Buildroot are always the other way around: you use a 'depends on' or a
'select' because you need some other thing.

Why isn't matchbox-common maybe always visible, like we do for all
packages ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com