[Buildroot] [PATCH v2 1/1] package/softether: Fix iconv-related compile error

[Bernd Kuhls]

[posted and mailed]

Peter Korsgaard <peter at korsgaard.com> wrote in 
news:8761a7jhks.fsf at dell.be.48ers.dk:

> > -ifeq ($(BR2_ENABLE_LOCALE),)
> > +ifeq ($(BR2_PACKAGE_LIBICONV),y)
> 
> Hmm, what does this really change? LIBICONV=y if !BR2_ENABLE_LOCALE, so
> these should be equivalent, right?

Hi,

I am not sure if I understood your question correctly. Currently libiconv is 
only taken into account as dependency if BR2_ENABLE_LOCALE=y, but it is also 
possible to have BR2_PACKAGE_LIBICONV=y if !BR2_ENABLE_LOCALE, just as you 
said. But the current code in buildroot git and my patched code do not 
function the same because the current git code ignores libiconv and leads to 
autobuild errors like these from today:

http://autobuild.buildroot.net/results/182/182e658723d654d45c683dc2bc0b959c82
c37826/
http://autobuild.buildroot.net/results/1e4/1e4af4642691ea9681b39eb1ce4f8107e8
c3ff5f/

Regards, Bernd