[Buildroot] [PATCH v2] Makefile: Remove 'quiet' variable
Cédric Marie
cedric.marie at openmailbox.org
Thu Oct 8 20:03:37 UTC 2015
'quiet' variable is set and exported, but it is not used. We can safely
remove it.
This variable is inherited from the Makefile of the Linux kernel, and
is not used in Buildroot.
In support/scripts/mkmakefile, 'quiet' value is checked, but the test
is always true ('quiet' is never set to silent_), so the test can be
removed as well.
Signed-off-by: Cédric Marie <cedric.marie at openmailbox.org>
---
Changes v1 -> v2:
- KBUILD_VERBOSE must not be removed, it is used for packages based
on Kbuild.
Title of PATCH v1 was:
Makefile: Remove KBUILD_VERBOSE and quiet
In order to describe how the verbosity level is managed in different
infrastructures, comments will be added in Makefile (suggested by Arnout).
It will be provided in a separate patch.
Arnout also suggested not to export 'Q', which seems to be Buildroot
internal. This will also be provided in a separate patch, if confirmed.
---
Makefile | 4 +---
support/scripts/mkmakefile | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 181d446..470ea65 100644
--- a/Makefile
+++ b/Makefile
@@ -226,14 +226,12 @@ ifndef KBUILD_VERBOSE
endif
ifeq ($(KBUILD_VERBOSE),1)
- quiet =
Q =
ifndef VERBOSE
VERBOSE = 1
endif
export VERBOSE
else
- quiet = quiet_
Q = @
endif
@@ -245,7 +243,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
# kconfig uses CONFIG_SHELL
CONFIG_SHELL := $(SHELL)
-export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
+export SHELL CONFIG_SHELL Q KBUILD_VERBOSE
ifndef HOSTAR
HOSTAR := ar
diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
index 833be6a..37162a3 100755
--- a/support/scripts/mkmakefile
+++ b/support/scripts/mkmakefile
@@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
then
exit 0
fi
-if [ "${quiet}" != "silent_" ]; then
- echo " GEN $2/Makefile"
-fi
+echo " GEN $2/Makefile"
cat << EOF > $2/Makefile
# Automatically generated by $0: don't edit
--
2.6.1
More information about the buildroot
mailing list