[Buildroot] [PATCH v2 2/2] package/kodi-screensaver-rsxs: new package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Oct 18 21:26:35 UTC 2015
Bernd,
On Sun, 18 Oct 2015 14:11:26 +0200, Bernd Kuhls wrote:
> ++get_filename_component( COMPILER_FILENAME "${CMAKE_C_COMPILER}" NAME )
> ++string( REGEX REPLACE "-[^-]+$" ""
> ++ TOOLCHAIN_NAME "${COMPILER_FILENAME}" )
> ++
Same as for the goom one: can you submit this upstream?
> diff --git a/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk b/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk
> new file mode 100644
> index 0000000..2df7683
> --- /dev/null
> +++ b/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# kodi-screensaver-rsxs
> +#
> +################################################################################
> +
> +KODI_SCREENSAVER_RSXS_VERSION = 195e0ec3fbbcb2ee2012cd560e42d05167f0f259
> +KODI_SCREENSAVER_RSXS_SITE = $(call github,notspiff,screensavers.rsxs,$(KODI_SCREENSAVER_RSXS_VERSION))
Can you add the licensing information? I know there is none in the
upstream package, but this is not normal. Can you ask upstream to add
licensing details ?
Also, for github packages, we now what to have a hash file. Can you add
one (for both this one and goom) ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list