[Buildroot] [Patch v2 3/9] s6: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Dec 13 21:55:23 UTC 2016


Hello,

On Sun, 11 Dec 2016 19:38:26 +0100, Eric Le Bihan wrote:

> > > +define S6_INSTALL_STAGING_CMDS
> > > +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> > > +endef  
> >
> > You're doing a plain "make install" here.
> >  
> > > +define HOST_S6_INSTALL_CMDS
> > > +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
> > > +		install-dynlib \
> > > +		install-include
> > > +endef  
> >
> > but not here. Why?  
> 
> The host variant of s6 builds some process supervision programs that I
> deemed unuseful for the user, and only the libraries and headers are
> needed to build the host variants of execline and s6-rc. But it is true
> that this also applies to the staging directory. So, I'll use
> "install-dynlib install-include" in this case too.

Or just use plain "make install" everywhere. We really don't care about
disk space in HOST_DIR or STAGING_DIR, so simplicity should win.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list