[Buildroot] [PATCH 1/1] iputils: resolve musl compatibility

[Matthew Weber]

Thomas,

On Tue, Jan 19, 2016 at 3:13 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Matt,
>
> Some more comments (see below).
>
> On Mon, 18 Jan 2016 03:50:44 +0000, Matt Weber wrote:
>
>> diff --git a/package/iputils/iputils.hash b/package/iputils/iputils.hash
>> index 21a2044..fcca52c 100644
>> --- a/package/iputils/iputils.hash
>> +++ b/package/iputils/iputils.hash
>> @@ -1,2 +1,4 @@
>> +# Locally computed
>> +sha256       0e98cb527fa175d1e08afb969c124e452b30968f10ec2c3b078f1440c8977a94        iputils-c8ff6feaf0442f8efd96ccb415770c54f9e84d47.tar.gz
>>  # From http://sourceforge.net/projects/iputils/files/
>>  sha1 3e85179746fd93000d6267bd55addfe97f321ba7        iputils-s20121011.tar.bz2
>
> Why are you keeping the hash for the old tarball ?

No reason, will remove.

>
>> diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
>> index 7510d99..d427b11 100644
>> --- a/package/iputils/iputils.mk
>> +++ b/package/iputils/iputils.mk
>> @@ -4,13 +4,12 @@
>>  #
>>  ################################################################################
>>
>> -IPUTILS_VERSION = s20121011
>> -IPUTILS_SITE = http://www.skbuff.net/iputils
>> -IPUTILS_SOURCE = iputils-$(IPUTILS_VERSION).tar.bz2
>> -IPUTILS_LICENSE = GPLv2+, BSD-3c
>> +IPUTILS_VERSION = c8ff6feaf0442f8efd96ccb415770c54f9e84d47
>> +IPUTILS_SITE = $(call github,iputils,iputils,$(IPUTILS_VERSION))
>
> I don't understand why you are moving to github.
> http://www.skbuff.net/iputils has some recent tarballs, which
> correspond to the releases made on github.
> http://www.skbuff.net/iputils/iputils-s20151218.tar.bz2 will most
> likely contain the musl fixes.

The releases don't match.  The github repository was forked in 2014 to
pull fixes from other distrobutions and centralize the changes after
the upstream seemed to have gone dormant.  So the fork is the only
repo that has the musl and other IPv6 updates.  I should have
referenced the email link.
http://www.spinics.net/lists/netdev/msg279881.html
Thoughts?

>
> I'll mark your patch as Changes Requested in patchwork. Can you respin
> after fixing the issues raised during the review?

Will do.

-- 
Thanks,
Matt