[Buildroot] [PATCH v1 1/1] package/busybox: support spaces in module aliases in mdev

[Yann E. MORIN]

Andy, Thomas, All,

On 2016-07-01 22:54 +0200, Thomas Petazzoni spake thusly:
> On Fri,  1 Jul 2016 21:56:19 +0300, Andy Shevchenko wrote:
> > The new change which enabled automatic module loading on boot does not handle
> > the cases when module alias includes spaces. It prevents modules to be loaded
> > since script fails:
> > 
> >   % find /sys/ -name modalias | xargs sort -u
> >   sort: /sys/devices/platform/Fixed: No such file or directory
> > 
> > First alias in question is "platform:Fixed MDIO bus".
> > 
> > Amend the script to support above like cases.
> > 
> > Fixes: 07f46c2b6dae ("package/busybox: support automatic module loading with mdev")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> 
> Thanks for this patch. However, I have one question below.
> 
> > -	find /sys/ -name modalias | xargs sort -u | xargs modprobe -abq
> > +	find /sys -name modalias -print0 | xargs -0 sort -u | while read ma; do
> 
> Why is /sys/ changed to /sys ?
> 
> Is it because of the sort -u that you cannot do another xargs -0 for
> the modprobe (which would look nice that the "while read ... done"
> loop) ?

sort has a -z option to output with zero-teminated lines instead of \n.
So we could do (almost untested):

    find /sys/ -name modalias -print0 |xargs -0 sort -u -z |xargs -0 modprobe -abq

Note: the -z option to sort in Busybox depends on SORT_BIG, which is
enabled in out busybox bundled configuration, so we can use it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'