[Buildroot] [PATCH] slang: make install-static do install-pkgconfig

Peter Korsgaard peter at korsgaard.com
Sun Mar 13 20:44:29 UTC 2016


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

Hi,

 >> Patch description and signed-off-by missing. Alternatively we can drop
 >> the patch and just pass install-pkgconfig to the 'make install' step as
 >> we already need to use a custom make target anyway.

 > That's what Max did in his first patch, and I asked him to do it in our
 > patch.
 > The .pc file is not installed for static-only because *we* added a patch
 > that breaks down install into install-staging and install-shared.

But that patch is an upstream patch:

Repository: git://git.jedsoft.org/git/slang.git
Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02
Author: John E. Davis <jed at jedsoft.org>

So just changing what the patch does without updating the comment is
imho not the right way to go. We should instead add a 0003 patch and
send it upstream.

-- 
Venlig hilsen,
Peter Korsgaard 



More information about the buildroot mailing list