[Buildroot] [PATCH v7 03/18] core: re-enter make if $(CURDIR) or $(O) are not absolute canonical path

Samuel Martin s.martin49 at gmail.com
Tue Mar 22 05:55:17 UTC 2016


Hi Matthew,

On Tue, Mar 22, 2016 at 4:03 AM, Matthew Weber <matt at thewebers.ws> wrote:
> Samuel,
>
> On Mon, Mar 21, 2016 at 6:40 AM, Matthew Weber <matt at thewebers.ws> wrote:
>> Samuel,
>>
>> On Mon, Mar 21, 2016 at 12:21 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
>>> On Mon, Mar 21, 2016 at 2:45 AM, Matthew Weber <matt at thewebers.ws> wrote:
>>>> Samuel, All,
>>>>
>>>> On Sun, Mar 20, 2016 at 8:44 PM, Matthew Weber <matt at thewebers.ws> wrote:
>>>>> Samuel,
>>>>>
>>
>> <snip>
>>>
>
> Narrowed it down to removing "O=$(realpath $(O))" on line 50 in the
> Makefile resolves the build error.  If I understand it correctly this
> is declaring O= empty and it causes the logic on 127 to evaluate to
> False and O= ends up as empty.
>
> I applied your 02/18 patch on top of
> 0e1547a87cfd51e4fedf1cb7837f77e4f66c4052 when I tested.
>
Thanks for investigating this.
Unfortunately, I could not reproduce this issue here with make-4.1. :-/
(I wonder whether this could be related to the make version...)

Anyway, following Yann's review, I have reworked this patch [1].
If you give a try to this patch, care to tell me if it fixes your issue.

[1] https://github.com/tSed/buildroot/commit/c55eeee30fe6106354c0f2cb6ce6ecb46972503a

Regards,

>
> --
> Thanks,
> Matt


-- 
Samuel



More information about the buildroot mailing list