[Buildroot] [PATCH] fs/ext2: fix double quoted label
Gaël PORTAY
gael.portay at savoirfairelinux.com
Wed Nov 16 19:55:42 UTC 2016
Hi all,
Since the commit 6dd7bbb59134799ed3d7343f238b3b02592faebf, the label does
not need anymore to be quoted. Even worse it *must* not be simple-quoted,
unless the label will contain the double-quotes from the config variable
BR2_TARGET_ROOTFS_EXT2_LABEL.
The commit mentionned above has replaced echo by printf:
- echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT)
+ $$(call PRINTF,$$(ROOTFS_$(2)_CMD)) >> $$(FAKEROOT_SCRIPT)
Since this commit the rootfs label contains extra double-quotes.
$ blkid
/dev/mmcblk0: LABEL=""BR 2016.08"" UUID="xxx"
^ ^
With this fix, the extra double-quotes have disappeared:
# blkid
/dev/mmcblk0: LABEL="BR 2016.11-rc2" UUID="yyy"
Note: I tested the fix under pseudo and fakeroot, even if has nothing
to deal with this those tools.
Regards,
Gaël PORTAY (1):
fs/ext2: fix double quoted label
fs/ext2/ext2.mk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.10.2
More information about the buildroot
mailing list