[Buildroot] [PATCH 1/1] package/opencv3: use BR2_TOOLCHAIN_HAS_LIBATOMIC

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Sep 5 21:25:39 UTC 2016


Hello,

On Mon, 5 Sep 2016 23:20:00 +0200, Samuel Martin wrote:

> > +# Uses __atomic_fetch_add_4
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> > +OPENCV3_CONF_OPTS += -DCMAKE_CXX_FLAGS="-latomic"
> > +endif  
> 
> Since you add the dependency on BR2_TOOLCHAIN_HAS_ATOMIC in the
> Config.in, I wonder whether nested conf. opts. update in a if-block
> that will always be true is really necessary...

You're confusing BR2_TOOLCHAIN_HAS_ATOMIC with
BR2_TOOLCHAIN_HAS_LIBATOMIC. There's a subtle difference :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list