[Buildroot] cpprestsdk: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Aug 1 11:25:41 UTC 2017


Hello,

On Tue, 1 Aug 2017 06:27:50 -0400, Dave Bender wrote:
> Added cpprestsdk library
> 
> Signed-off-by: David Bender <codehero at gmail.com>

Thanks for this new submission. However, please apply the same comments
as the ones I made for your squashfs-fuse patch: entry to DEVELOPERS
file, fix indentation, etc.


> diff --git a/package/cpprestsdk/Config.in b/package/cpprestsdk/Config.in
> new file mode 100644
> index 000000000..beb37ad17
> --- /dev/null
> +++ b/package/cpprestsdk/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_CPPRESTSDK
> + bool "cpprestsdk"
> + select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_CHRONO
> + select BR2_PACKAGE_BOOST_FILESYSTEM
> + select BR2_PACKAGE_BOOST_RANDOM
> + select BR2_PACKAGE_BOOST_REGEX
> + select BR2_PACKAGE_BOOST_SYSTEM
> + select BR2_PACKAGE_BOOST_THREAD
> + select BR2_PACKAGE_OPENSSL

You forgot to propagate the dependencies.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list