[Buildroot] Analysis of build results for 2017-08-14

[Arnout Vandecappelle]

On 17-08-17 09:09, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 16 Aug 2017 21:00:26 -0500, Matthew Weber wrote:
> 
>>>  I think it's best to put the empty _SITE check in an
>>> ifneq ($(BR2_PRIMARY_SITE_ONLY),y)
>>
>> https://patchwork.ozlabs.org/patch/802290/
> 
> I know this is what Arnout suggested, but I'm not sure it's my
> preferred fix. Indeed, what about instead dropping the:
> 
> if !BR2_PRIMARY_SITE_ONLY
> ...
> endif
> 
> condition in Config.in that encloses the definition of BR2_GNU_MIRROR,
> BR2_LUAROCKS_MIRROR, etc. ?
> 
> Even though I agree such variables are not used when
> BR2_PRIMARY_SITE_ONLY=y, I don't see why we hide them. Removing this
> condition in Config.in avoids the need for adding another condition in
> pkg-generic.mk, and it seems more logical to me.

 Works for me.

 Matthew, sorry for the bad suggestion :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF