[Buildroot] [PATCH v2 3/3] package/lugaru: new package

[Romain Naour]

Hi Thomas, All,

Le 26/02/2017 à 14:59, Thomas Petazzoni a écrit :
> Hello,
> 
> On Sat, 25 Feb 2017 14:36:00 +0100, Romain Naour wrote:
> 
>> +LUGARU_CONF_OPTS = -DSYSTEM_INSTALL=ON \
>> +	-DCMAKE_INSTALL_BINDIR=games \
>> +	-DCMAKE_INSTALL_DATADIR=share/games
> 
> Why are we passing custom CMAKE_INSTALL_<foo>DIR here?

We have to set SYSTEM_INSTALL otherwise the application "will default to looking
for the data in the 'Data' directory next to the binary"

But I've keep the custom CMAKE_INSTALL_<foo>DIR from the example in COMPILING.md
file... We can remove them.

Thanks for the review.

Best regards,
Romain

> 
> The rest of the patch looks good to me.
> 
> Thanks!
> 
> Thomas
>