[Buildroot] [PATCH 1/2] efl: fix target package dependency on util-linux (libmount).

[Romain Naour]

Hi Gustavo,

Le 03/01/2017 à 22:29, Gustavo Sverzut Barbieri a écrit :
> use the correct variable (BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT) and do
> not impose dependency on util-linux if not needed.
> 
> Signed-off-by: Gustavo Sverzut Barbieri <barbieri at profusion.mobi>
> ---
>  package/efl/Config.in | 6 +++---
>  package/efl/efl.mk    | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index c51fc564d..542c354a8 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -17,9 +17,6 @@ config BR2_PACKAGE_EFL
>  	# https://phab.enlightenment.org/T2728
>  	select BR2_PACKAGE_LUAJIT # Lua support broken
>  	select BR2_PACKAGE_LZ4
> -	select BR2_PACKAGE_UTIL_LINUX
> -	# libblkid is part of required tools, see EFL's README.
> -	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID

IIRC, There is a build issue behind this, but it was with an older efl version
(1.13 or 1.14). So I have to check this.

BTW do you want to be added to DEVELOPERS file and receive any build issues from
Buildroot autobuilders related to efl packages ?

https://buildroot.org/downloads/manual/manual.html#DEVELOPERS

>  	select BR2_PACKAGE_ZLIB
>  	help
>  	  Enlightenment Foundation Libraries
> @@ -101,7 +98,10 @@ config BR2_PACKAGE_EFL_PULSEAUDIO
>  
>  config BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT
>  	bool "Enable libmount support (recommended)"

Maybe we should rename this option to BR2_PACKAGE_EFL_UTIL_LINUX and use
"Enable util-linux (limbount + libblkid) support (recommended)"

Best regards,
Romain

> +	select BR2_PACKAGE_UTIL_LINUX
>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> +	# libblkid is part of required tools, see EFL's README.
> +	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>  	default y
>  	help
>  	  Libmount is used heavily inside Eeze for support of removable
> diff --git a/package/efl/efl.mk b/package/efl/efl.mk
> index 2fe140a30..ab08946c4 100644
> --- a/package/efl/efl.mk
> +++ b/package/efl/efl.mk
> @@ -20,7 +20,7 @@ EFL_LICENSE_FILES = \
>  EFL_INSTALL_STAGING = YES
>  
>  EFL_DEPENDENCIES = host-pkgconf host-efl host-luajit dbus freetype \
> -	jpeg luajit lz4 udev util-linux zlib
> +	jpeg luajit lz4 udev zlib
>  
>  # Configure options:
>  # --disable-lua-old: build elua for the target.
> @@ -59,7 +59,7 @@ else
>  EFL_CONF_OPTS += --disable-cxx-bindings
>  endif
>  
> -ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
> +ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)
>  EFL_DEPENDENCIES += util-linux
>  EFL_CONF_OPTS += --enable-libmount
>  else
>