[Buildroot] [PATCH] ncftp: fix host/target confusion

[Yann E. MORIN]

Thomas, All,

On 2017-02-28 23:54 +0100, Thomas Petazzoni spake thusly:
> The ncftp build process tries to build and run a small program called
> ccdv to beautify the build process output. If it manages to build and
> run it, then it uses it.
> 
> Unfortunately, this doesn't work well when the target architecture is
> close to the host architecture, but not exactly the same. Because both
> architectures are close to each other, the test run of ccdv succeeds,
> but real use of ccdv during ncftp build process causes an Illegal
> instruction issue.
> 
> This for example happens with the CodeSourcery AMD64 toolchain, on a
> build machine running an i7-4600U, and has been detected in the
> autobuilders since the CodeSourcery AMD64 toolchain was upgraded at
> the end of January:
> 
>   http://autobuild.buildroot.net/?reason=ncftp-3.2.6
> 
> The issue was also reported by Christopher Arguin back in July 2016:
> 
>   http://lists.busybox.net/pipermail/buildroot/2016-July/168026.html
> 
> and at the time, we identified that simply disabling the ccdv tool, by
> passing --disable-ccdv, was enough to solve the issue. But Christopher
> never submitted the patch, so the problem remained unfixed.
> 
> Therefore, we pass --disable-ccdv to the configure script, which
> fixes:
> 
>   http://autobuild.buildroot.net/results/6eadad0e879ca70bb07b13b4196d42c64b11699f/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/ncftp/ncftp.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
> index 5c88556..11bfcca 100644
> --- a/package/ncftp/ncftp.mk
> +++ b/package/ncftp/ncftp.mk
> @@ -12,6 +12,7 @@ NCFTP_LICENSE = Clarified Artistic License
>  NCFTP_LICENSE_FILES = doc/LICENSE.txt
>  
>  NCFTP_DEPENDENCIES = host-autoconf
> +NCFTP_CONF_OPTS = --disable-ccdv
>  
>  # The bundled configure script is generated by autoconf 2.13 and doesn't
>  # detect cross-compilation correctly. Therefore, we have to regenerate it.
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'