[Buildroot] [PATCH 6/6] libubox: enable static build

[Arnout Vandecappelle]

On 24-03-17 13:49, Rahul Jain wrote:
> upstream has added the support to build the static libraries.
> update comment for BR2_STATIC_LIBS for other packages having
> dependency on libubox.

 The reason why that comment is there, is so we remember that when libubox is
allowed to be built statically, we should check if ubus and ustream-ssl perhaps
now also can be built statically. So, did you check that? If yes, you should
update the comment as to why they can't be build statically (e.g. "dlopen()",
see other Config.in files).

 Regards,
 Arnout

> 
> Signed-off-by: Rahul Jain <Rahul.Jain at imgtec.com>
> ---
>  package/libubox/Config.in     | 4 ----
>  package/ubus/Config.in        | 2 +-
>  package/ustream-ssl/Config.in | 2 +-
>  3 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/package/libubox/Config.in b/package/libubox/Config.in
> index 25ef4bb..ba10f8d 100644
> --- a/package/libubox/Config.in
> +++ b/package/libubox/Config.in
> @@ -1,6 +1,5 @@
>  config BR2_PACKAGE_LIBUBOX
>  	bool "libubox"
> -	depends on !BR2_STATIC_LIBS
>  	help
>  	  This library originates from the OpenWrt project to
>  	  handle the configuration file infrastructure, but can
> @@ -8,6 +7,3 @@ config BR2_PACKAGE_LIBUBOX
>  	  than OpenWrt.
>  
>  	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
> -
> -comment "libubox needs a toolchain w/ dynamic library"
> -	depends on BR2_STATIC_LIBS
> diff --git a/package/ubus/Config.in b/package/ubus/Config.in
> index c14f6a8..84e13f8 100644
> --- a/package/ubus/Config.in
> +++ b/package/ubus/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_UBUS
>  	select BR2_PACKAGE_LIBUBOX
>  	select BR2_PACKAGE_JSON_C
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
> -	depends on !BR2_STATIC_LIBS # libubox
> +	depends on !BR2_STATIC_LIBS
>  	help
>  	  IPC/RPC bus that allows communication between processes.
>  
> diff --git a/package/ustream-ssl/Config.in b/package/ustream-ssl/Config.in
> index 540e436..a12c37b 100644
> --- a/package/ustream-ssl/Config.in
> +++ b/package/ustream-ssl/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_USTREAM_SSL
>  	bool "ustream-ssl"
> -	depends on !BR2_STATIC_LIBS #libubox
> +	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_LIBUBOX
>  	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_MBEDTLS
>  	help
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF