[Buildroot] [PATCH 2/3] core: allow having a list of "cmake" candidates

Carlos Santos casantos at datacom.ind.br
Fri May 5 22:43:42 UTC 2017


> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> To: "Carlos Santos" <casantos at datacom.ind.br>
> Cc: buildroot at buildroot.org
> Sent: Friday, May 5, 2017 6:09:28 PM
> Subject: Re: [Buildroot] [PATCH 2/3] core: allow having a list of "cmake" candidates
>> @@ -10,9 +10,10 @@
>>  #
>>  BR2_CMAKE_VERSION_MIN = 3.1
>>  
>> -BR2_CMAKE ?= cmake
>> -ifeq ($(call suitable-host-package,cmake,\
>> -	$(BR2_CMAKE) $(BR2_CMAKE_VERSION_MIN)),)
>> +BR2_CMAKE_CANDIDATES ?= cmake
> 
> Do not rename the variable; keep it named BR2_CMAKE.
> 
> It was named as such so that one could do:
> 
>    $ make BR2_CMAKE=/path/to/my/cmake3
> 
> and we want to keep it as such, so people can override the cmake they
> want to use.
> 
> By the way, I hope you knew you could do that, didn't you? ;-)

I did not rename the variable. It is still BR2_CMAKE and you still can
pass it in the command line (yes, I knew).

>> +BR2_CMAKE ?= $(call suitable-host-package,cmake,\
    ^^^^^^^^^^^^^

>> +	$(BR2_CMAKE_CANDIDATES) $(BR2_CMAKE_VERSION_MIN))
>> +ifeq ($(BR2_CMAKE),)
>>  BR2_CMAKE = $(HOST_DIR)/usr/bin/cmake
>>  BR2_CMAKE_HOST_DEPENDENCY = host-cmake
>>  endif
>> --
>> 1.8.3.1

-- 
Carlos Santos (Casantos) - DATACOM, P&D
“The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.” — Christopher Hitchens



More information about the buildroot mailing list