[Buildroot] [PATCH 1/2] package/pkg-golang: use 'build' instead of 'install'
Peter Korsgaard
peter at korsgaard.com
Sun Apr 1 14:35:47 UTC 2018
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
> Minor nit...
> On 01-04-18 13:51, Thomas Petazzoni wrote:
>> @@ -102,7 +102,9 @@ define $(2)_BUILD_CMDS
>> $$(GO_TARGET_ENV) \
>> GOPATH="$$(@D)/$$($(2)_WORKSPACE)" \
>> $$($(2)_GO_ENV) \
>> - $$(GO_BIN) install -v $$($(2)_BUILD_OPTS) ./$$(d)
>> + $$(GO_BIN) build -v $$($(2)_BUILD_OPTS) \
>> + -o $$(@D)/$$($(2)_BINDIR)/$$(if $$($(2)_BIN_NAME),$$($(2)_BIN_NAME),$$(notdir $$(d))) \
> I find the $(or ...) construct to be more readable:
> -o $$(@D)/$$($(2)_BINDIR)/$$(or $$($(2)_BIN_NAME),$$(notdir $$(d))) \
We do use a lot more $(if than $(or, but OK - $(or is shorter.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list