[Buildroot] [PATCHv2 1/1] utils/checkpackagelib: add function to check of the default package source variable
Jerzy Grzegorek
jerzy.m.grzegorek at gmail.com
Wed Jan 10 21:36:15 UTC 2018
Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek at gmail.com>
Cc: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
---
Changes v1 -> v2
- remove unused variable (Ricardo Martincoski)
- change warning url (Ricardo Martincoski)
- add whitelist of packages (Ricardo Martincoski)
utils/checkpackagelib/lib_mk.py | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py
index 817e809..a0ed1ae 100644
--- a/utils/checkpackagelib/lib_mk.py
+++ b/utils/checkpackagelib/lib_mk.py
@@ -99,6 +99,33 @@ class PackageHeader(_CheckFunction):
text]
+class RemoveDefaultPackageSourceVariable(_CheckFunction):
+ packages_that_may_contain_default_source = ["binutils","gcc","gdb"]
+ PACKAGE_NAME = re.compile("/([^/]+)\.mk")
+
+ def before(self):
+ package = self.PACKAGE_NAME.search(self.filename).group(1)
+ package_upper = package.replace("-", "_").upper()
+ self.package = package
+ self.FIND_SOURCE = re.compile(
+ "^{}_SOURCE\s*=\s*{}-\$\({}_VERSION\)\.tar\.gz"
+ .format(package_upper, package, package_upper))
+
+ def check_line(self, lineno, text):
+ if self.FIND_SOURCE.search(text):
+
+ if self.package in self.packages_that_may_contain_default_source:
+ return ["{}:{}: this package may contain default value of "
+ "_SOURCE variable to remove ({}#generic-package-reference)"
+ .format(self.filename, lineno, self.url_to_manual),
+ text]
+
+ return ["{}:{}: remove default value of _SOURCE variable "
+ "({}#generic-package-reference)"
+ .format(self.filename, lineno, self.url_to_manual),
+ text]
+
+
class SpaceBeforeBackslash(_CheckFunction):
TAB_OR_MULTIPLE_SPACES_BEFORE_BACKSLASH = re.compile(r"^.*( |\t)\\$")
--
1.9.1
More information about the buildroot
mailing list