[Buildroot] [PATCH 3/4] support/testing: fix python syntax
Ricardo Martincoski
ricardo.martincoski at gmail.com
Sun Jun 3 04:24:37 UTC 2018
Hello,
On Sat, Jun 02, 2018 at 07:19 PM, Yann E. MORIN wrote:
> We're about to switch to using the flake8 from the distro, and that one
> uncovers two more issues that the previously used pip-provided one did
> not catch:
See my comments to patch 4. What generates more warnings is the fact that we
start using Python3 interpreter to call flake8.
We can call this patch a step towards Python 3 support for the test infra.
[snip]
> ---
> support/testing/infra/__init__.py | 6 +++---
> support/testing/infra/basetest.py | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
By running one of below commands (after the others from .gitlab-ci.yml) I get:
$ python3 -m flake8 --statistics --count $(cat files.processed)
$ flake8 --statistics --count $(cat files.processed)
support/testing/infra/basetest.py:49:28: E999 SyntaxError: invalid syntax
support/testing/infra/__init__.py:37:29: E999 SyntaxError: invalid syntax
support/testing/run-tests:44:29: E999 SyntaxError: invalid syntax
3 E999 SyntaxError: invalid syntax
3
So it seems support/testing/run-tests also needs to be changed.
Regards,
Ricardo
More information about the buildroot
mailing list