[Buildroot] [PATCH 4/4] package/rpi-firmware: improve installation of dtb files

[Yann E. MORIN]

Martin, All,

On 2018-03-15 19:58 +0000, Martin Bark spake thusly:
> On 15 March 2018 at 19:40, Peter Seiderer <ps.report at gmx.net> wrote:
> > On Thu, 15 Mar 2018 13:24:51 +0000, Martin Bark <martin at barkynet.com> wrote:
> >> Don't list specific dtb files, instead install all dtb files in the same
> >> way as dtbo files are currently done.
> >>
> >> Signed-off-by: Martin Bark <martin at barkynet.com>
> >> ---
> >>  package/rpi-firmware/rpi-firmware.mk | 7 +++----
> >>  1 file changed, 3 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> >> index 1ebdd96..9cc3d4a 100644
> >> --- a/package/rpi-firmware/rpi-firmware.mk
> >> +++ b/package/rpi-firmware/rpi-firmware.mk
> >> @@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
> >>
> >>  ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
> >>  define RPI_FIRMWARE_INSTALL_DTB
> >> -     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
> >> -     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
> >> -     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
> >> -     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
> >> +     for dtb in  $(@D)/boot/*.dtb; do \
> >> +             $(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
> >> +     done
> >
> > Which will install three additional dtb files (bcm2708-rpi-0-w.dtb,
> > bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the
> > patch, but worth mentioning....
> 
> Yes, it will also install the new bcm2710-rpi-3-b-plus.dtb. This code
> does not seem to have been kept updated, it's missing several dtb
> files as you mention.  I think it's better to just install all dtb
> files as we do for the dtbo files.

I wonder if we should not just drop BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
now the rpi dtbs are now supposed to be in the kernel snce at least 3.19.

Besids, all our rpi defconfig are using the DT from the kernel, which is
another good indication that we don't need those from rpi-firmware
anymore...

If it is not yet in the kernel, it is just a matter of time before it is
available there...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'