[Buildroot] [git commit] linux: don't override HOSTCC for kconfig

[Scott Fan]

I think it should be also committed to the 2018.02.x branch.

Thanks.


On Fri, May 18, 2018, 02:54 Thomas Petazzoni <thomas.petazzoni at bootlin.com>
wrote:

> commit:
> https://git.buildroot.net/buildroot/commit/?id=6d3d09e23213e88c14f2ddc883700499315a41bc
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Kconfig uses either pkg-config or hard-coded /usr/include paths to find
> the ncurses or ncursesw library. If ncursesw is found, it will include
> <ncursesw.h>. Since Buildroot's host-ncurses doesn't install a .pc file,
> and linux.mk anyway doesn't pass the pkg-config options to find the host
> pkg-config files, Kconfig will always find the system's ncursesw.h.
>
> However, since commit dde090c299 (linux: fix passing of host CFLAGS and
> LDFLAGS) HOST_LDFLAGS is passed to the linux build system. Thus, if
> host-ncurses was already built before 'make linux-menuconfig' is called,
> the build will pick up libncurses from the host directory, which is NOT
> widechar. Thus, two different ncurses configurations are mixed into the
> final mconf program. This will result in serious breakage in the
> rendering of the menus (lots of @ and question mark characters).
>
> As a workaround (suggested by Yann), don't pass HOST_CFLAGS and
> HOST_LDFLAGS when running kconfig commands. For kconfig, we should never
> need host packages anyway. This way, the kconfig calls will always use
> the system's ncurses and never our host-ncurses.
>
> Note that the same problem could pop up for other kconfig packages as
> well if we ever pass HOST_CFLAGS/HOST_LDFLAGS to them. We could force
> HOSTCC=$(HOSTCC) directly in kconfig-package. However, for now there
> are no other packages that exhibit this problem, so this can be
> revisited when they do.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Cc: David De Grave <david.degrave at essensium.com>
> Cc: Scott Fan <fancp2007 at gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> Tested-by: Matt Weber <matthew.weber at rockwellcollins.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> ---
>  linux/linux.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index b6b91391b6..6b5f5344ed 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -235,7 +235,14 @@ LINUX_KCONFIG_FILE = $(call
> qstrip,$(BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE))
>  endif
>  LINUX_KCONFIG_FRAGMENT_FILES = $(call
> qstrip,$(BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES))
>  LINUX_KCONFIG_EDITORS = menuconfig xconfig gconfig nconfig
> -LINUX_KCONFIG_OPTS = $(LINUX_MAKE_FLAGS)
> +
> +# LINUX_MAKE_FLAGS overrides HOSTCC to allow the kernel build to find our
> +# host-openssl and host-libelf. However, this triggers a bug in the
> kconfig
> +# build script that causes it to build with /usr/include/ncurses.h (which
> is
> +# typically wchar) but link with $(HOST_DIR)/lib/libncurses.so (which is
> not).
> +# We don't actually need any host-package for kconfig, so remove the
> HOSTCC
> +# override again.
> +LINUX_KCONFIG_OPTS = $(LINUX_MAKE_FLAGS) HOSTCC="$(HOSTCC)"
>
>  # If no package has yet set it, set it from the Kconfig option
>  LINUX_NEEDS_MODULES ?= $(BR2_LINUX_NEEDS_MODULES)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20180531/5cc41956/attachment-0001.html>