[Buildroot] [PATCH 1/1] xerces: enable threads if available
Matthew Weber
matthew.weber at rockwellcollins.com
Sat Oct 6 20:59:24 UTC 2018
Fabrice,
On Sat, Oct 6, 2018 at 3:13 PM Fabrice Fontaine
<fontaine.fabrice at gmail.com> wrote:
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Reviewed-by: Matt Weber <matthew.weber at rockwellcollins.com>
> ---
> package/xerces/xerces.mk | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/package/xerces/xerces.mk b/package/xerces/xerces.mk
> index a25641fb45..da088d8e1c 100644
> --- a/package/xerces/xerces.mk
> +++ b/package/xerces/xerces.mk
> @@ -10,9 +10,7 @@ XERCES_SITE = http://archive.apache.org/dist/xerces/c/3/sources
> XERCES_LICENSE = Apache-2.0
> XERCES_LICENSE_FILES = LICENSE
> XERCES_INSTALL_STAGING = YES
> -XERCES_CONF_OPTS = \
> - --disable-threads \
I went back and checked the history on why threading was disabled by
default. It looks like there wasn't a specific reason. Just a
package bump and change of configuration style.
https://git.busybox.net/buildroot/commit/package/xerces/xerces.mk?id=324f61f7982c64ebd4a457467b33a6984bd8a584
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +XERCES_CONF_OPTS += --enable-threads
> +else
> +XERCES_CONF_OPTS += --disable-threads
> +endif
> +
Does this yield a pretty good performance increase? Wonder how they
bound the thread number to use on target when it runs.
Matt
More information about the buildroot
mailing list