[Buildroot] [PATCH v3] eudev: generate hwdb.bin at system startup

[Matthew Weber]

On Mon, Oct 29, 2018 at 9:34 AM Carlos Santos <casantos at datacom.com.br> wrote:
>
> > From: "Matthew Weber" <matthew.weber at rockwellcollins.com>
> > To: "DATACOM" <casantos at datacom.com.br>
> > Cc: "buildroot" <buildroot at buildroot.org>, "Bernd Kuhls" <bernd.kuhls at t-online.de>, "Eric Le Bihan"
> > <eric.le.bihan.dev at free.fr>, "Yann Morin" <yann.morin.1998 at free.fr>, "Carlos Santos" <casantos at datacom.ind.br>
> > Sent: Monday, October 29, 2018 11:11:17 AM
> > Subject: Re: [PATCH v3] eudev: generate hwdb.bin at system startup
>
> > Carlos,
> >
> > On Tue, Oct 16, 2018 at 12:02 PM Carlos Santos <casantos at datacom.com.br> wrote:
> >>
> >> From: Carlos Santos <casantos at datacom.ind.br>
> [...]
> >>  ifeq ($(BR2_PACKAGE_EUDEV_ENABLE_HWDB),y)
> >>  EUDEV_CONF_OPTS += --enable-hwdb
> >> +define EUDEV_POST_PATCH
> >> +       $(SED)
> >> 's,$${udevconfdir}/hwdb.bin,$${udevhwdbbinpath:-$${udevconfdir}/hwdb.bin},' \
> >> +               $(@D)/configure
> >> +endef
> >> +EUDEV_POST_PATCH_HOOKS += EUDEV_POST_PATCH
> >> +EUDEV_CONF_ENV += udevhwdbbinpath=$(BR2_PACKAGE_EUDEV_HWDB_BIN_PATH)
> >
> > I believe BR2_PACKAGE_EUDEV_HWDB_BIN_PATH needs a qstrip?
>
> Not really, since the quotes are properly handled and may even be even
> required in the unlikely situation of BR2_PACKAGE_EUDEV_HWDB_BIN_PATH
> containing white spaces.
>
> --
> Carlos Santos (Casantos) - DATACOM, P&D
> “Marched towards the enemy, spear upright, armed with the certainty
> that only the ignorant can have.” — Epitaph of a volunteer

Reviewed-by: Matt Weber <matthew.weber at rockwellcollins.com>