[Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package
Adrian Perez de Castro
aperez at igalia.com
Thu Sep 27 12:44:11 UTC 2018
Hello Peter,
On Thu, 27 Sep 2018 13:37:48 +0200, Peter Korsgaard <peter at korsgaard.com> wrote:
> >>>>> "Adrian" == Adrian Perez de Castro <aperez at igalia.com> writes:
>
> Hi,
>
> >> However, since woff2 has very few dependencies, and
> >> woff2+brotli+host-pkgconf build in 19 seconds, it's nothing compared to
> >> webkitgtk, so I applied your patch.
>
> > I will make a follow-up patch to make WOFF2 optional. I think it should be
> > fine to enable it by default if BR2_PACKAGE_WOFF2 is enabled, and add a line
> > in the help description telling that it is recommended to enable it.
>
> Correct. Now that we have updated kconfig we could even consider using
> the imply keyword to enable woff2 by default if it is really an option
> that most people should enable:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=237e3ad0f195d8fd34f1299e45f04793832a16fc
This is just perfect. Thanks for pointing this out :-)
Cheers,
-Adrián
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20180927/0110fa8b/attachment-0001.asc>
More information about the buildroot
mailing list