[Buildroot] [PATCH v2 2/3] docs/website/js/buildroot.js: Fix possible type coercion

Angelo Compagnucci angelo at amarulasolutions.com
Mon Feb 4 15:16:47 UTC 2019


On Mon, Feb 4, 2019 at 3:27 PM <aduskett at gmail.com> wrote:
>
> From: Adam Duskett <Aduskett at gmail.com>
>
> With javascript, when comparing variables, using === instead of ==
> is preferred.
>
> Signed-off-by: Adam Duskett <Aduskett at gmail.com>
Acked-by: <angelo at amarulasolutions.com>
Tested-by: <angelo at amarulasolutions.com>
> ---
> Changes v1 -> v2:
>   - Updated to apply to latest master commit.
>
>  docs/website/js/buildroot.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/website/js/buildroot.js b/docs/website/js/buildroot.js
> index 3e6ff0d20b..1b08f9b4df 100644
> --- a/docs/website/js/buildroot.js
> +++ b/docs/website/js/buildroot.js
> @@ -11,7 +11,7 @@ function load_activity(feedurl, divid) {
>          if (result==null) return;
>          for (let i = 0; i < result.feed.entry.length; i++) {
>              let entry = result.feed.entry[i];
> -            if (entry.title.indexOf("git commit") != -1)
> +            if (entry.title.indexOf("git commit") !== -1)
>                  continue;
>              loaded += 1;
>              if (loaded > nb_display)
> @@ -44,7 +44,7 @@ function google_analytics() {
>      let ga = document.createElement('script');
>      ga.type = 'text/javascript';
>      ga.async = true;
> -    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
> +    ga.src = ('https:' === document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
>      let s = document.getElementsByTagName('script')[0];
>      s.parentNode.insertBefore(ga, s);
>  }
> @@ -67,7 +67,7 @@ clipboard.on('success', function(e) {
>
>  $(function() {
>    $('a[href*=\\#]:not([href=\\#])').click(function() {
> -    if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'') && location.hostname == this.hostname) {
> +    if (location.pathname.replace(/^\//,'') === this.pathname.replace(/^\//,'') && location.hostname === this.hostname) {
>          let target = $(this.hash);
>        target = target.length ? target : $('[name=' + this.hash.slice(1) +']');
>        if (target.length) {
> --
> 2.17.2 (Apple Git-113)
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



More information about the buildroot mailing list