[Buildroot] [PATCH 1/1] package/wine: Add gettext dependency for host-wine only with NLS enabled

Vadim Kochan vadim4j at gmail.com
Fri Jan 4 13:58:51 UTC 2019


Hi Thomas,

On Fri, Jan 4, 2019 at 2:42 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello,
>
> On Fri,  4 Jan 2019 13:49:09 +0200, Vadim Kochan wrote:
> > Checked that host-wine compiles ok without host-gettext, so no
> > needs to specify this dependency.
> >
> > libgettextpo is required by tools/wrc (https://linux.die.net/man/1/wrc)
> > which allows to convert windows resources also to *.po format, which is
> > not needed if NLS is disabled.
> >
> > Signed-off-by: Vadim Kochan <vadim4j at gmail.com>
> > ---
> >  package/wine/wine.mk | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/package/wine/wine.mk b/package/wine/wine.mk
> > index 78c8e6ab63..ef70b6276c 100644
> > --- a/package/wine/wine.mk
> > +++ b/package/wine/wine.mk
> > @@ -307,8 +307,10 @@ WINE_CONF_OPTS += --without-zlib
> >  endif
> >
> >  # host-gettext is essential for .po file support in host-wine wrc
> > +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
> >  HOST_WINE_DEPENDENCIES += host-gettext
> >  HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
> > +endif
>
> It probably needs a "else" clause, to pass --without-gettext
> --without-gettextpo.

Emm, I will include this patch (with your suggestion) into gettext-tiny series.

Thanks,
Vadim Kochan



More information about the buildroot mailing list