[Buildroot] [PATCH 03/19] autobuild-run: move njobs from kwargs to Builder class

Atharva Lele itsatharva at gmail.com
Tue Jun 25 04:53:25 UTC 2019


On Tue, Jun 25, 2019 at 3:04 AM Arnout Vandecappelle <arnout at mind.be> wrote:
>
> On 21/06/2019 10:47, Atharva Lele wrote:
> > Signed-off-by: Atharva Lele <itsatharva at gmail.com>
> >      for i in range(0, int(args['--ninstances'])):
> > -        builder = Builder(i)
> > +        builder = Builder(i, args['--njobs'])
>
>  Since there will be a lot of arguments in the end, it would be better to make
> it more explicit, similar like it was in kwargs, i.e.
>
>      builder = Builder(i
>          njobs = args['--njobs'])
>
>  Still, not essential, so
>  Regards,
>  Arnout

It makes sense to have it more explicit. I'll have it in the v2.

Regards,
Atharva Lele



More information about the buildroot mailing list