[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

Peter Seiderer ps.report at gmx.net
Wed May 8 17:43:10 UTC 2019


Hello *,

On Wed, 08 May 2019 09:26:09 +0200, Peter Korsgaard <peter at korsgaard.com> wrote:

> >>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
>
>  > On 07/05/2019 23:02, Peter Korsgaard wrote:
>  >>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:
>  >>
>  >> > Hello Peter,
>  >> > On Tue,  7 May 2019 22:35:21 +0200
>  >> > Peter Seiderer <ps.report at gmx.net> wrote:
>  >>
>  >> >> Signed-off-by: Peter Seiderer <ps.report at gmx.net>
>  >> >> ---
>  >> >> package/assimp/assimp.mk | 2 +-
>  >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>  >>
>  >> > Thanks for all those patches. I think it would be useful to extend the
>  >> > check-package logic to check that such UTF-8 quotes/spaces don't get
>  >> > re-added.
>  >>
>  >> Agreed!
>
>  >  I think in Config.in, *.mk and *.hash we should never need any non-ascii
>  > character, so that check would be easy.

First draft, checking only the .mk files, just sent out, see [1]...

>
> I am not so sure about Config.in. If you look at:
>
> package/intel-mediasdk/Config.in
> package/imagemagick/Config.in
> package/zeromq/Config.in
> package/directfb/Config.in
>
> They have UTF-8 copyright characters, a funny e in bezier and the OE in
> zeromq.
>

- do not check (and keep as is)
- whitelist for some special characters (per file?)
- convert to plain ascii, e.g: (R), bezier, zeromq (without the specail zero)...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/1097166/



More information about the buildroot mailing list