[Buildroot] [PATCH v14 4/5] package/pkg-meson.mk: set Python sysconfigdata

Arnout Vandecappelle arnout at mind.be
Wed Oct 23 21:03:25 UTC 2019



On 23/10/2019 22:50, Thomas Petazzoni wrote:
> On Wed, 23 Oct 2019 13:42:54 -0700
> Adam Duskett <aduskett at gmail.com> wrote:
> 
>>>  Adam, could you test if this works better?
>>>
>>> +       $$(if
>>> $$(BR2_PACKAGE_PYTHON3),_PYTHON_SYSCONFIGDATA_NAME="$$(PKG_PYTHON_SYSCONFIGDATA_NAME)")
>>> \  
>> $$(if $$(BR2_PACKAGE_PYTHON3),_PYTHON_SYSCONFIGDATA_NAME="$$(PKG_PYTHON_SYSCONFIGDATA_NAME),_sysconfigdata)"
>> Also does not work, because the target python3 may not yet be built.

 Ugh indeed, another side effect of this environment being used for both "host"
python and "cross" python...

 I'm starting to think this is not such a good solution after all...


> But that is totally unrelated to the _sysconfigdata "fallback" that I
> was criticizing. The issue of "you're passing
> _PYTHON_SYSCONFIG_DATA_NAME regardless of whether Python was built
> before or not" was already present in your initial submission.

 With "initial submission", do you mean *my* initial submission (i.e. this patch
4/5 from v14), or Adam's initial submission which patched meson itself and which
was taken over from yocto? The latter did not actually change sysconfigdata at
all; instead it patched meson to not make use of the pkg_config_libdir that
comes out of sysconfigdata (which is I think the only thing from sysconfigdata
that is actually used by meson).

 I'll dive into the meson code again to see if I can find something better...

 Regards,
 Arnout



More information about the buildroot mailing list