[Buildroot] [PATCH 00/18] Improve alphabetical order checking of Config.in files

Jerzy Grzegorek jerzy.m.grzegorek at gmail.com
Wed Sep 25 08:05:23 UTC 2019


Hi Ricardo,

> Hello,
>
> Thank you for working on this.
>
> On Tue, Sep 03, 2019 at 06:03 PM, Jerzy Grzegorek wrote:
>
>> The main purpose of this patch series is to improve alphabetical order
>> checking of comments, menus and packages in Config.in files.
>> Patches 1-11 are preliminary ones and add small improvements.
>> Patches 12, 14, 15 do the main work.
>> Patches 13, 16-18 fix issues in  Config.in files.
> I completely understand why you developed the patches in this order.
> But usually when applying changes in the script that imply fixes/changes in
> other files, we do apply the other way around. First fixes, then the script
> that detect the error just corrected.


Yes, you are right, but I had no idea about these errors. They appeared 
after improving this script.

Thank you for the review.

Regards,
Jerzy


>> Jerzy Grzegorek (18):
>>    checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: rename
>>      variable 'm'
> Here and in many more patches I guess a better prefix for the subject would be:
> utils/checkpackagelib:
>
>
> Regards,
> Ricardo





More information about the buildroot mailing list