[Buildroot] [PATCH 5/8] core/show-info: report whether a package is overriden

[Thomas Petazzoni]

On Sat, 11 Apr 2020 11:44:36 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:

> > I don't have a good suggestion, but I'm not sure "overriden" is the
> > most appropriate term. Indeed, the download/extract/patch steps are
> > also replaced by a rsync step for packages that use _SITE_METHOD =
> > local, and such packages are not "overriden".  
> 
> It is very unfortunate that we conflate the two conditions.

Well, from an internal implementation point of view, SITE_METHOD =
local and OVERRIDE_SRCDIR are just exactly the same thing.

Perhaps you could use:

	"rsynced": $(if $($(1)_OVERRIDE_SRCDIR),true,false),

as this is really annotates the fact that the package source code is
rsynced. You could even make it clearer with "source-rsynced" or
something like that.

> We can't even reconstruct the override by looking at whether
> _SITE_METHOD == local, because even local packages may be overriden...

Indeed.

> So, is it worth that I try and untangle the tow notions? Given the
> feedback on the rest of this eries, I don;t want to invest too much time
> if there is no chance of it getting in...

I think this particular patch is OK, even though admittedly the
external tool could just watch for the correct stamp files to show up:
if .stamp_downloaded shows up, we're downloading it normally, if
.stamp_rsynced shows up, we have a local or overridden package.

In the design of the tool, it would be good to make sure that top-level
parallel build is taken into account.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com