[Buildroot] [PATCH v3 3/7] package/cups: fix cups service
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Tue Aug 4 21:38:10 UTC 2020
Hello Angelo,
On Wed, 24 Jun 2020 22:43:43 +0200
Angelo Compagnucci <angelo at amarulasolutions.com> wrote:
> Cups service for systemv was erroneously installed in /etc/rcX.d and
> therefore not working.
> This patch adds also a buildroot style systemv init script instead of
> using the example provided by the package.
>
> Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>
Thanks, I have applied, after some changes. See below.
> +start() {
> + printf 'Starting %s: ' "$DAEMON"
> + # shellcheck disable=SC2086 # we need the word splitting
> + start-stop-daemon -b -m -S -q -p "$PIDFILE" -x "/sbin/$DAEMON" \
I don't know how this was tested: cupsd is installed in /usr/sbin/, not
in /sbin/. Or perhaps you had a merged /usr and so you didn't notice ?
> + --libdir=/usr/lib \
> + --with-rcdir=no
Changed to:
--without-rcdir
I looked at the code and tested it, and it works as expected.
> +define CUPS_INSTALL_INIT_SYSV
> + $(RM) $(TARGET_DIR)/etc/init.d/cups
This is not needed: --without-rcdir ensures it is not installed. So I
dropped this line.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list