[Buildroot] [PATCH v2] package/htpdate: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Sep 7 21:51:20 UTC 2020


Hello Angelo,

On Fri,  7 Aug 2020 22:58:06 +0200
Angelo Compagnucci <angelo at amarulasolutions.com> wrote:

> Adding htpdate, a time syncronization software based on http.
> 
> Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>

I've applied after fixing some minor issues. First, some check-package
warnings:

package/Config.in:2085: Packages in: menu "Networking applications",
                        are not alphabetically ordered;
                        correct order: '-', '_', digits, capitals, lowercase;
                        first incorrect package: hplip
package/htpdate/Config.in:5: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

> +HTPDATE_VERSION = 1.2.4
> +HTPDATE_SITE = $(call github,angeloc,htpdate,v$(HTPDATE_VERSION))
> +HTPDATE_LICENSE = GPL-2.0-or-later

We use GPL-2.0+ in Buildroot, not GPL-2.0-or-later.

> +define HTPDATE_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) CC=$(TARGET_CC) $(MAKE) -C $(@D) $(HTPDATE_BUILD_OPTS)

I've changed CC=$(TARGET_CC) to $(TARGET_CONFIGURE_OPTS) so that our
CFLAGS are passed.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list